Slim down integrations api for pandas and gds #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicola Vitucci <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the integration APIs for pandas and GDS by removing automatic node sizing and property-to-field mapping capabilities. Instead of configuring these features through function parameters, users now configure them directly on the VisualizationGraph object after creation.
Key Changes:
- Removed
node_radius_min_maxparameter fromfrom_dfs,from_gds, andfrom_snowflakefunctions - Renamed
additional_node_propertiestonode_propertiesandadditional_db_node_propertiestodb_node_propertiesinfrom_gds - Changed integration functions to only map basic fields (id, caption, source, target) instead of all matching field names
- Added automatic node coloring by label in
from_gds
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| python-wrapper/tests/test_pandas.py | Updated tests to remove node_radius_min_max parameter and validate nodes store size/color in properties instead of fields |
| python-wrapper/tests/test_gds.py | Removed tests for automatic sizing and validation, updated assertions to include color field, renamed parameter references |
| python-wrapper/src/neo4j_viz/visualization_graph.py | Added comprehensive documentation with examples for VisualizationGraph class and constructor |
| python-wrapper/src/neo4j_viz/snowflake.py | Removed node_radius_min_max parameter and updated documentation |
| python-wrapper/src/neo4j_viz/relationship.py | Added basic_fields_validation_aliases() helper method |
| python-wrapper/src/neo4j_viz/pandas.py | Removed sizing logic and property renaming, changed to only map basic fields as mandatory fields instead of all matching aliases |
| python-wrapper/src/neo4j_viz/node.py | Added basic_fields_validation_aliases() helper method |
| python-wrapper/src/neo4j_viz/gds.py | Removed size property mapping and added automatic node coloring, renamed parameters |
| docs/source/integration.rst | Updated documentation to reflect API changes and new usage patterns |
| docs/source/conf.py | Added sphinx configuration for documentation rendering |
| changelog.md | Documented breaking changes and parameter renames |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adamnsch
reviewed
Oct 21, 2025
adamnsch
reviewed
Oct 21, 2025
adamnsch
reviewed
Oct 23, 2025
adamnsch
reviewed
Oct 23, 2025
adamnsch
reviewed
Oct 23, 2025
adamnsch
reviewed
Oct 23, 2025
adamnsch
approved these changes
Oct 23, 2025
instead of inside from_pandas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.